Skip to content

FIX: Handle consecutive wildcards in StringMatches#2310

Closed
josepmariapujol-unity wants to merge 4 commits intodevelopfrom
input/removing-legacy-todos-2
Closed

FIX: Handle consecutive wildcards in StringMatches#2310
josepmariapujol-unity wants to merge 4 commits intodevelopfrom
input/removing-legacy-todos-2

Conversation

@josepmariapujol-unity
Copy link
Collaborator

@josepmariapujol-unity josepmariapujol-unity commented Jan 7, 2026 •
edited
Loading

Description

Removing TODO for handle consecutive wildcards in StringMatches.

Testing status & QA

Not tested

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity: low
  • Halo Effect: low

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@josepmariapujol-unity josepmariapujol-unity self-assigned this Jan 7, 2026
@u-pr
Copy link
Contributor

u-pr bot commented Jan 7, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

The change is small and localized, but it touches string matching semantics where a few edge cases should be validated.
🏅 Score: 92

The implementation is straightforward and removes a known TODO, but should be backed by targeted tests to lock in intended wildcard behavior.
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Edge Cases

Validate that collapsing consecutive * does not alter intended escaping behavior (e.g., patterns like \**), and that patterns with consecutive wildcards in the middle behave identically to a single wildcard across all expected inputs.

 
// Collapse consecutive '*' so we don't end up with `**` semantics here.
while (posInStr + 1 < strLength && str[posInStr + 1] == '*')
    ++posInStr;
Test Coverage

Add/confirm unit tests covering consecutive wildcards (**, ***), wildcard at end (*), wildcard between literals (a**b), and interactions with escaped characters to prevent regressions in path matching.

 
// Collapse consecutive '*' so we don't end up with `**` semantics here.
while (posInStr + 1 < strLength && str[posInStr + 1] == '*')
    ++posInStr;

if (posInStr == strLength - 1)
    return true; // Wildcard at end of string so rest is matched.
  • Update review

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

@u-pr
Copy link
Contributor

u-pr bot commented Jan 7, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@codecov-github-com
Copy link

codecov-github-com bot commented Jan 7, 2026 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...putsystem/InputSystem/Controls/InputControlPath.cs 50.00% 1 Missing ⚠️ 
@@             Coverage Diff             @@
##           develop    #2310      +/-   ##
===========================================
- Coverage    77.95%   77.95%   -0.01%     
===========================================
  Files          476      476              
  Lines        97443    97443              
===========================================
- Hits         75961    75960       -1     
- Misses       21482    21483       +1
Flag Coverage Δ
inputsystem_MacOS_2022.3 5.54% <0.00%> (-0.01%) ⬇️
inputsystem_MacOS_2022.3_project 75.47% <50.00%> (-0.01%) ⬇️
inputsystem_MacOS_6000.0 5.32% <0.00%> (-0.01%) ⬇️
inputsystem_MacOS_6000.0_project 77.37% <50.00%> (+<0.01%) ⬆️
inputsystem_MacOS_6000.3 5.32% <0.00%> (-0.01%) ⬇️
inputsystem_MacOS_6000.3_project 77.36% <50.00%> (-0.01%) ⬇️
inputsystem_MacOS_6000.4 5.32% <0.00%> (-0.01%) ⬇️
inputsystem_MacOS_6000.4_project 77.36% <50.00%> (-0.01%) ⬇️
inputsystem_MacOS_6000.5 5.32% <0.00%> (-0.01%) ⬇️
inputsystem_MacOS_6000.5_project 77.36% <50.00%> (+<0.01%) ⬆️
inputsystem_Ubuntu_2022.3 5.54% <0.00%> (-0.01%) ⬇️
inputsystem_Ubuntu_2022.3_project 75.26% <50.00%> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.0 5.32% <0.00%> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.0_project 77.17% <50.00%> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.3 5.32% <0.00%> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.3_project 77.16% <50.00%> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.4 5.33% <0.00%> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.4_project 77.17% <50.00%> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.5 5.33% <0.00%> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.5_project 77.17% <50.00%> (-0.01%) ⬇️
inputsystem_Windows_2022.3 5.54% <0.00%> (-0.01%) ⬇️
inputsystem_Windows_2022.3_project 75.60% <50.00%> (-0.01%) ⬇️
inputsystem_Windows_6000.0 5.32% <0.00%> (-0.01%) ⬇️
inputsystem_Windows_6000.0_project 77.49% <50.00%> (-0.01%) ⬇️
inputsystem_Windows_6000.3 5.32% <0.00%> (-0.01%) ⬇️
inputsystem_Windows_6000.3_project 77.49% <50.00%> (-0.01%) ⬇️
inputsystem_Windows_6000.4 5.32% <0.00%> (-0.01%) ⬇️
inputsystem_Windows_6000.4_project 77.49% <50.00%> (-0.01%) ⬇️
inputsystem_Windows_6000.5 5.32% <0.00%> (-0.01%) ⬇️
inputsystem_Windows_6000.5_project 77.49% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...putsystem/InputSystem/Controls/InputControlPath.cs 91.79% <50.00%> (-0.09%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@josepmariapujol-unity josepmariapujol-unity changed the title Handle consecutive wildcards in StringMatches FIX: Handle consecutive wildcards in StringMatches Jan 8, 2026
@ekcoh
Copy link
Collaborator

ekcoh commented Jan 13, 2026

@josepmariapujol-unity Is this PR still relevant? Or was it superseded by the related PR?

@josepmariapujol-unity
Copy link
Collaborator Author

josepmariapujol-unity commented Jan 16, 2026

Closing this PR since changes have landed in this other PR: #2311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@josepmariapujol-unity josepmariapujol-unity

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@josepmariapujol-unity @ekcoh